-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve delivered metrics #204
Conversation
Pull request title looks good 👍! If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time. This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...This project uses a special format for pull requests titles. Don't worry, it's easy! This pull request title should be in this format:
If your pull request introduces breaking changes to the code, use this format:
where
Examples:
Need more examples? Want to learn more about this format? Check out the official docs. Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests. |
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
============================================
- Coverage 63.52% 62.70% -0.83%
- Complexity 218 231 +13
============================================
Files 91 94 +3
Lines 2051 2145 +94
Branches 263 281 +18
============================================
+ Hits 1303 1345 +42
- Misses 646 691 +45
- Partials 102 109 +7
|
Build available to test |
messagingpush/src/main/java/io/customer/messagingpush/util/PushTrackingUtil.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/util/PushTrackingUtil.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/CustomerIOFirebaseMessagingReceiver.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/util/PushTrackingUtil.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/CustomerIOFirebaseMessagingReceiver.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/CustomerIOFirebaseMessagingReceiver.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/processor/PushMessageProcessorImpl.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/processor/PushMessageProcessorImpl.kt
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/processor/PushMessageProcessorImpl.kt
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/processor/PushMessageProcessorImpl.kt
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/CustomerIOFirebaseMessagingReceiver.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/CustomerIOFirebaseMessagingReceiver.kt
Outdated
Show resolved
Hide resolved
messagingpush/src/main/java/io/customer/messagingpush/processor/PushMessageProcessorImpl.kt
Show resolved
Hide resolved
### [3.5.1](3.5.0...3.5.1) (2023-06-01) ### Bug Fixes * improve delivered metrics ([#204](#204)) ([831d1d9](831d1d9))
closes: https://github.com/customerio/issues/issues/10066
Changes
CustomerIOFirebaseMessagingReceiver
for trackingdelivered
using C2DM callbacks from GCMJvmStatic
to methods fromCustomerIOFirebaseMessagingService
context
to create and retrieve SDK instance in push modulePushTrackingUtil
to remove redundant code