Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve delivered metrics #204

Merged
merged 25 commits into from
Jun 1, 2023
Merged

fix: improve delivered metrics #204

merged 25 commits into from
Jun 1, 2023

Conversation

mrehan27
Copy link
Contributor

closes: https://github.com/customerio/issues/issues/10066

Changes

  • CustomerIOFirebaseMessagingReceiver for tracking delivered using C2DM callbacks from GCM
  • JvmStatic to methods from CustomerIOFirebaseMessagingService
  • Extension function on context to create and retrieve SDK instance in push module
  • Refactored PushTrackingUtil to remove redundant code

@mrehan27 mrehan27 self-assigned this May 12, 2023
@github-actions
Copy link

github-actions bot commented May 12, 2023

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter 

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #204 (cd38594) into main (3ed104a) will decrease coverage by 0.83%.
The diff coverage is 41.37%.

@@             Coverage Diff              @@
##               main     #204      +/-   ##
============================================
- Coverage     63.52%   62.70%   -0.83%     
- Complexity      218      231      +13     
============================================
  Files            91       94       +3     
  Lines          2051     2145      +94     
  Branches        263      281      +18     
============================================
+ Hits           1303     1345      +42     
- Misses          646      691      +45     
- Partials        102      109       +7     
Impacted Files Coverage Δ
.../customer/messaginginapp/di/DIGraphMessaginIApp.kt 0.00% <0.00%> (ø)
...ustomer/messaginginapp/provider/GistApiProvider.kt 0.00% <0.00%> (ø)
...ssaginginapp/provider/GistInAppMessagesProvider.kt 56.75% <0.00%> (-3.25%) ⬇️
...essagingpush/CustomerIOFirebaseMessagingService.kt 0.00% <0.00%> (ø)
...messagingpush/CustomerIOPushNotificationHandler.kt 0.00% <0.00%> (ø)
...omer/messagingpush/extensions/ContextExtensions.kt 0.00% <0.00%> (ø)
...stomer/sdk/CustomerIOActivityLifecycleCallbacks.kt 7.40% <0.00%> (-4.36%) ⬇️
...java/io/customer/sdk/data/request/DeliveryEvent.kt 0.00% <0.00%> (ø)
sdk/src/main/java/io/customer/sdk/di/DiGraph.kt 100.00% <ø> (ø)
...java/io/customer/sdk/repository/TrackRepository.kt 57.57% <0.00%> (-10.29%) ⬇️
... and 8 more

@github-actions
Copy link

Build available to test
Version: fix-gcm-delivered-metrics-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@mrehan27 mrehan27 requested a review from a team May 12, 2023 13:47
@mrehan27 mrehan27 marked this pull request as ready for review May 12, 2023 13:47
@mrehan27 mrehan27 requested review from levibostian and Shahroz16 May 23, 2023 12:52
@mrehan27 mrehan27 merged commit 831d1d9 into main Jun 1, 2023
@mrehan27 mrehan27 deleted the fix/gcm-delivered-metrics branch June 1, 2023 15:29
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
### [3.5.1](3.5.0...3.5.1) (2023-06-01)

### Bug Fixes

* improve delivered metrics ([#204](#204)) ([831d1d9](831d1d9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants