-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resh-collect ERROR: 2020/07/01 20:46:23 resh-daemon is not running - try restarting this terminal #148
Comments
Hi, thanks for the report. Logs for the daemon are located in |
Based on the log, what I think is happening is that, when I run a command and ctrl-C it, sometimes that interrupt is being handled by resh - causing it to shut down. I ctrl-C relatively aggressively, it seems. I'm not sure what a workaround/fix for this might be, though ... but it is a tad annoying. Often I can bring everything back online by just sourcing my bash profile again - but sometimes that seems not to work. I'll add a log if I can reproduce that again. |
That's a spot on analysis. Here's a bit more in-depth explanation of what is happening. The resh daemon is launched whenever you open a new terminal but only if it's not running already. When you run your first terminal after booting up the resh daemon is launched by that terminal. Every process that is launched from a terminal belongs to the same process group. When you press When you press This is obviously something we don't want to happen. On Linux I have found a way to take the resh daemon process out of the process group so it doesn't receive the signals from the terminal. On MacOS I couldn't find a simple way to do this. There is definitely a way I just didn't have time to find it at the time. To make things worse, when the daemon gets killed and it is relaunched by the next new terminal the issue can happen again. How to avoid the issueSince the daemon is only "bound" to one terminal you can prevent the issue by closing the first terminal you open after booting up. I'm not saying this is a good solution. I want to properly solve this issue but in the meantime this might make your experience with resh more consistent. Especially if the issue just happened to you. You can open a terminal to launch the daemon and then close it to prevent any signals from being sent to the daemon. I hope this helps a little bit. Definitely thank you for the report. This kind of feedback is essential when I'm deciding what issues and problems to focus on next. |
Thanks for the detailed explanation. I'll try the proposed workaround - if it's effective then I can adapt to just doing that relatively easily. Great work 👍 |
In Kubuntu 20.04, first time opening terminal after boot I get the same error. Every time I had to restart terminal.
|
@RrajibB Can you create a new issue because it seems like your issue is different than this one?Also can you please run |
I hit this all the time and its honestly pretty frustrating. If you |
This issue should be fixed in version 2.8.0. Could somebody on macOS test that the issue is actually gone. |
@tivvit confirmed that the daemon is no longer getting killed by Ctrl+C key presses. Feel free to reopen if the issue persists for you. |
Installing again fixed my issues |
In the last few weeks, I've constantly found myself getting hit with this error:
resh-collect ERROR: 2020/07/01 20:46:23 resh-daemon is not running - try restarting this terminal
It doesn't seem to be caused by anything particular that I can nail down. Not sure where log files are but happy to share them if you can point me in the right direction. It's pretty frustrating.
The text was updated successfully, but these errors were encountered: