Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear after" doesn't work as expected #208

Closed
pokey opened this issue Aug 9, 2021 · 6 comments
Closed

"Clear after" doesn't work as expected #208

pokey opened this issue Aug 9, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@pokey
Copy link
Member

pokey commented Aug 9, 2021

I would expect it to delete the trailing delimiter and leave the cursor there

@pokey pokey added the bug Something isn't working label Aug 9, 2021
@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Aug 9, 2021

Well after inner selection is just "end of". So far only outer selection has anything to do with delimiters. So I would argue that it actually does exactly what I expected it to :D

@pokey
Copy link
Member Author

pokey commented Aug 10, 2021

Then how would you propose to do what I wanted to have happen? It is useful functionality. I guess I could do "clear outer after". But we're kind of wasting the "after" / "end of" distinction in this case.

We could have a "trailing delimiter" / "leading delimiter" modifier rather than reusing "before" / "after". We might then even remove support for positional modifiers in arbitrary places and restrict them to things like "bring after". We'd then still need an answer for "past end of". Idk

@AndreasArvidsson
Copy link
Member

AndreasArvidsson commented Aug 10, 2021

This is a hard one. We could always add a proper position for end of but we still have a problem with change after air to hello that command shouldn't actually replace anything and just insert the text after.
We could of course make the actions themselves aware of different positions and have different actions do different things with the after position, but that's a tricky one as well.

@pokey
Copy link
Member Author

pokey commented Aug 16, 2021

So I think based on our last discussion, we want to support this one, no? Because "after" would transform the selection into something where the content itself is the delimiter, so "clear" would target it

@AndreasArvidsson
Copy link
Member

Yes this will be supported after we do the new oo targets.

@pokey
Copy link
Member Author

pokey commented Jan 18, 2022

Better to solve this one with #309

@pokey pokey closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants