Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract #steps and #step into a separate plugin gem #401

Closed
mattwynne opened this issue Mar 21, 2013 · 13 comments
Closed

Extract #steps and #step into a separate plugin gem #401

mattwynne opened this issue Mar 21, 2013 · 13 comments
Labels
⌛ stale Will soon be closed by stalebot unless there is activity

Comments

@mattwynne
Copy link
Member

Born of #273. This would mean that Cucumber, out of the box, does not support this feature which many of us consider to be an anti-pattern. You'd have to opt-in to use it.

This might interest you @tooky, since you're all over those nested steps at the moment. :) How possible do you think it would be?

@adbatista
Copy link
Contributor

I would like to try this. It will be a good way to learn more about Cucumber's source code.
But I think i'll need some help in beginning to undestand how this part works

@mattwynne
Copy link
Member Author

Thanks @adbatista. TBH I don't know how we'd do this just yet, and I don't want to think about it while we still have @wip tests failing on the master branch. Could you help us with those first?

@adbatista
Copy link
Contributor

@mattwynne, all tests are green, are these tests breaking in some specific version or interpreter?

@mattwynne
Copy link
Member Author

If you check out the master branch and run cucumber -p @wip you'll see there are still about 50 scenarios failing due to regressions. We need to fix all those before we can release even an alpha version of 2.0.

@nodo
Copy link
Member

nodo commented Sep 22, 2016

I would be happy to give this issue a go in order to progress the milestone. What do you think @mattwynne ? Is there anything more pressing?

@mattwynne
Copy link
Member Author

@nodo I haven't updated the 3.0.0 milestone in a while and I think this issue was just hanging around there. It would be nice to do it sometime, but it's not high priority I don't think.

I'm playing around with the new "Projects" feature in GitHub, so look there to help you figure out priorities, or ping me on gitter. Thanks for all your efforts so far, it's great to have you on the team!

@nodo
Copy link
Member

nodo commented Sep 25, 2016

Thanks @mattwynne , will keep an eye on projects or ping you!

@ericgriffis
Copy link

@mattwynne Has work been done already to this end? I would love to help make this happen, since we have an app that needs to access the steps of failing scenarios, but I don't know where to start

@mattwynne
Copy link
Member Author

Hi @ericgriffis can you tell me more about your use-case?

@mattwynne mattwynne removed this from the 3.0 milestone Sep 7, 2017
@stale
Copy link

stale bot commented Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Nov 8, 2017
@stale
Copy link

stale bot commented Nov 15, 2017

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this as completed Nov 15, 2017
@lock
Copy link

lock bot commented Nov 15, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2018
@mattwynne
Copy link
Member Author

mattwynne commented Oct 12, 2022

Ref: cucumber-attic/gherkin2#178

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⌛ stale Will soon be closed by stalebot unless there is activity
Projects
None yet
Development

No branches or pull requests

4 participants