Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubejs-schema-compiler): Support FILTER_GROUP in YAML models #8574

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

Fixes #8508

Description of Changes Made (if issue reference is not provided)

Add arglist node handling in transpiler, allows to generate function calls with multiple arguments, like FILTER_GROUP

Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 0:23am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 0:23am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 0:23am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 0:23am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 0:23am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 0:23am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 0:23am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 0:23am

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@mcheshkov mcheshkov merged commit f3b8b19 into master Aug 20, 2024
57 checks passed
@mcheshkov mcheshkov deleted the filter-group-in-yaml branch August 20, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FILTER_GROUP support in YAML data models
5 participants