Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a flexible search in LDAP for the REST API auth #123

Open
belyaev-andrey opened this issue Sep 30, 2020 · 0 comments
Open

Implement a flexible search in LDAP for the REST API auth #123

belyaev-andrey opened this issue Sep 30, 2020 · 0 comments
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@belyaev-andrey
Copy link

Implement a flexible search in LDAP for the REST API controller LdapAuthController. Now we have a hardcoded simple method

    protected String buildPersonFilter(String login) {
        AndFilter filter = new AndFilter();
        filter.and(new EqualsFilter("objectclass", "person"))
                .and(new EqualsFilter(ldapUserLoginField, login));
        return filter.encode();
    }

Which cannot be overridden properly because overriding a Controller with mapping in Spring might be a challenging task.

Suggestion:

Extract this method to a service that will build the filter. Services can be overridden easily in CUBA, therefore, users will be able to create their own filters for LDAP search.

@belyaev-andrey belyaev-andrey added the type: enhancement New feature or request label Sep 30, 2020
@knstvk knstvk assigned t2-cuba and unassigned zaharchenko-evgeny Oct 5, 2020
@knstvk knstvk added this to the Release 7.2 milestone Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants