deleteFile erase more files than expected

[matteo-cristino]

To reporduce the issue create a folder with the following form

test
├── path1
│   ├── file1.txt
│   └── folder1
│       └── file2.txt
└── path2
    ├── file1.txt
    └── folder1
        └── file2.txt

create a zip, for example on linux terminal with

zip -r test.zip test

Now run the following code

import AdmZip from "adm-zip";

let zip = new AdmZip("./test.zip");

console.log("* Before delete of test/path1/:");
zip.getEntries().forEach((entry) => {
  console.log(entry.entryName);
});

zip.deleteFile("test/path1/");

console.log("");
console.log("* After delete of test/path1/:");
zip.getEntries().forEach((entry) => {
  console.log(entry.entryName);
});

The result will be

* Before delete of test/path1/:
test/
test/path2/
test/path2/file1.txt
test/path2/folder1/
test/path2/folder1/file2.txt
test/path1/
test/path1/file1.txt
test/path1/folder1/
test/path1/folder1/file2.txt

* After delete of test/path1/:
test/
test/path2/
test/path2/file1.txt
test/path2/folder1/

As it can be seen during the deletion of /test/path1/ also /test/path2/folder1/file2.txt has been eliminated.

I have not debugged it to much, but from a first look to me it is that in the deleteFile function, in particular when eliminating the entry from the entryList here, the entry is not found and thus indexOf will return -1 that causes the elimination of the last element of the array.

[5saviahv]

Hmm, it seems there is error when deleting folders with multiple levels deep (with sub folder(s) ).

File is already deleted and searching its location with IndexOf returns -1. Since there is no value check, it will simply delete last entry.

adm-zip/zipFile.js

Line 221 in ef63cbb

entryList.splice(entryList.indexOf(entry), 1);

[matteo-cristino]

Thank you very much for the quick fix! 🎉

Do you know when a new release will be done to have this bug fixed?

[5saviahv]

fix should be in last release