Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store simtel metaparams in output HDF5 file #2674

Open
maxnoe opened this issue Jan 9, 2025 · 1 comment
Open

Store simtel metaparams in output HDF5 file #2674

maxnoe opened this issue Jan 9, 2025 · 1 comment
Labels
module:IO issues related to ctapipe.io

Comments

@maxnoe
Copy link
Member

maxnoe commented Jan 9, 2025

We should:

  • Add a generic way to include simulation configuration key/value pairs to DataWriter, not just the pre-configured run header container object
  • Include the simtel metaparams for simtel files

Some points:

  • This probably needs to happen by obs-id
  • Simtel metaparams are always string keys and string values, although values can semantically be anything (e.g. RANDOM_MONO_PROB is a float)
  • tables at the moment does not support variable length string tables, which will create some issues for this
@kosack
Copy link
Contributor

kosack commented Feb 5, 2025

Could we just add a way to dynamically add columns to the SimulationConfiguration? I guess that might break merging though if the number of columns is really different per observation, though we could just do an outer join in the merger.

It would be quiet easy to add a function like:

Container.add_dynamic_column(name:str, field:Field)`

@kosack kosack added the module:IO issues related to ctapipe.io label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:IO issues related to ctapipe.io
Projects
None yet
Development

No branches or pull requests

2 participants