Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to a sparse-sparse matmul case #2

Open
cshjin opened this issue Feb 27, 2020 · 0 comments
Open

Consider to a sparse-sparse matmul case #2

cshjin opened this issue Feb 27, 2020 · 0 comments
Assignees

Comments

@cshjin
Copy link
Owner

cshjin commented Feb 27, 2020

Overall, if we have two sparse matrices, then the multiplication should be sparse as well, in order to improve the performance.
Example like https://github.com/scipy/scipy/blob/a03f15fe43cb68c132192af22deb73b69ef201bf/scipy/sparse/compressed.py#L496-L530
And the spspmm function in the pytorch-sparse package. https://github.com/rusty1s/pytorch_sparse/blob/master/torch_sparse/spspmm.py

While in TF2.x, no matter the matmul (sparsetensor, sparsetensor) or the sparse.sparse_dense_matmul(sparsetensor, tensor) function return a Tensor instead of SparseTensor.

This is the one of the reasons why the PyG is much faster in the implementation of tensorflow or DGL.

Performance issue need to be resolved.

@cshjin cshjin self-assigned this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant