Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

[FEATURE] <Better sign up flow> #51

Closed
ykdojo opened this issue Aug 13, 2022 · 11 comments · Fixed by #124
Closed

[FEATURE] <Better sign up flow> #51

ykdojo opened this issue Aug 13, 2022 · 11 comments · Fixed by #124
Assignees
Labels
good first issue Good for newcomers

Comments

@ykdojo
Copy link
Collaborator

ykdojo commented Aug 13, 2022

Description

When a user signs up at /signup, confirming the email is required. I think we should make that clear.

Also, we should probably add some info about how to find the signup page (/signup) and the signin page (/signin) either on the site itself or in README.

@ykdojo ykdojo added the good first issue Good for newcomers label Aug 13, 2022
@Trowl3r
Copy link
Contributor

Trowl3r commented Aug 13, 2022

I would like to take this one on aswell. Little Idea: Maybe make a section with all the current pages in the README with all their corresponding .tsx files, aslong as we don't have a navbar?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 13, 2022

Sounds good! Having a navbar (or any other way of navigation) might be a good solution, also.

@pushkaraj2007
Copy link

I think we should use a package called 'nodemailer', for confirming the mail of users.

What do you think?

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 17, 2022

We're using Supabase right now, but that could definitely be an option maybe with NextAuth.

What would be the pros and cons of that approach?

@pushkaraj2007
Copy link

We're using Supabase right now, but that could definitely be an option maybe with NextAuth.

What would be the pros and cons of that approach?

As of I didn't worked much with supabase.

But if I talk about nodemailer, then I think it's a great library to send emails with ease.

Where you can send emails with just some lines of code like 15 - 20 and its fast as well.

The fall back is you can only authenticate the user by email. If you want to add other authentication options like google, GitHub then you have to add them by another method.

@ykdojo ykdojo moved this to Todo in defaang Aug 17, 2022
@ykdojo ykdojo added this to defaang Aug 17, 2022
@olamide203
Copy link
Contributor

olamide203 commented Aug 23, 2022

  • We could have a confirm-email page which a user gets redirected to from /signup on successful signup.
  • The confirm-email page would inform the user that a mail was sent to them containing a confirmation link.
  • when the user clicks on the link, they would be redirected to the main app dashboard by supabase
  • also links to signup and signin pages could be added to the navbar on the homepage

@ykdojo I'd like to give this a try if it hasn't been assigned to anyone yet

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 23, 2022

when the user clicks on the link, they would be redirected to the main app dashboard by supabase

I'm not sure what you mean by the main app dashboard by supabase here?

@ykdojo ykdojo assigned ykdojo and olamide203 and unassigned ykdojo Aug 23, 2022
@olamide203
Copy link
Contributor

olamide203 commented Aug 23, 2022

Supabase allows us to define the url a user gets redirected to on email confirmation. We can use that to redirect the user back to the part a user sees after signing in. for now it can just redirect to the lndex page which is the default

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 23, 2022

You meant index (/), right?

@olamide203
Copy link
Contributor

yea

@ykdojo
Copy link
Collaborator Author

ykdojo commented Aug 24, 2022

FYI, for the navbar, I created this separate issue. I think I'm going to work on that one next.

@ykdojo ykdojo moved this from To do to In review in defaang Aug 24, 2022
Repository owner moved this from In review to Done in defaang Aug 24, 2022
@subhoghoshX subhoghoshX moved this to Done in defaang Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants