Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

fix: better sign up flow (closes #215) #284

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: better sign up flow (closes #215) #284

wants to merge 3 commits into from

Conversation

abdelopx
Copy link

@abdelopx abdelopx commented Oct 9, 2022 •
edited
Loading

🛠️ Fixes Issue

Closes #215

➕ Changes Introduced

  • Disabled the 'sign up' button after that user clicked on it for the first time by adding a 'loading' state into the component
  • Added corresponding output on the button and style while it is loading to give the user a sense of what is happening.
  • Brought changes to the 'confirm-email' page by adding a 'Go to Sign in page' button to allow allow the user to go to the 'Sign In' page (which is more user-friendly and offers a smooth user experience).

📄 Note To Reviewers

📷 Screenshots

@vercel
Copy link

vercel bot commented Oct 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
defaang ✅ Ready (Inspect) Visit Preview Oct 10, 2022 at 9:23AM (UTC)

@github-actions github-actions bot added the title needs formatting Edit PR title to be in line with conventional commit message label Oct 9, 2022
@abdelopx abdelopx changed the title bug fix issue #215 fix: bug fix issue #215 Oct 9, 2022
@github-actions github-actions bot removed the title needs formatting Edit PR title to be in line with conventional commit message label Oct 9, 2022
@abdelopx abdelopx changed the title fix: bug fix issue #215 fix: better sign up flow #215 Oct 9, 2022
@abdelopx abdelopx changed the title fix: better sign up flow #215 fix: better sign up flow (closes #215) Oct 9, 2022
@abdelopx @subhoghoshX
Update src/pages/confirm-email.tsx
2bde777 
Co-authored-by: Subho <108616679+subhoghoshX@users.noreply.github.com>
@subhoghoshX
Copy link
Collaborator

Looks good, thank you :)

@ykdojo
Copy link
Collaborator

ykdojo commented Oct 10, 2022

Thank you.

I feel like this button should be styled a little bit more nicely though:

image

I just feel like it should be a little bit prettier.

ykdojo
ykdojo suggested changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@ykdojo ykdojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@subhoghoshX subhoghoshX mentioned this pull request Oct 11, 2022
Open
@Princeton21
Copy link

@abdelopx Are you working on improving the style of the button?

@abdelopx
Copy link
Author

Yep

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ykdojo ykdojo ykdojo requested changes

@subhoghoshX subhoghoshX subhoghoshX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] After clicking Signup, the screen shows like it's freezed
4 participants
@abdelopx @subhoghoshX @ykdojo @Princeton21