Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'error_no_match' does not get fired after the update from 0.7.1 to 1.1.0 #51

Closed
BogdanSinitsa opened this issue Mar 20, 2020 · 4 comments

Comments

@BogdanSinitsa
Copy link

BogdanSinitsa commented Mar 20, 2020

The callback onError does not get triggered when the error type is ''error_no_match"

But there are logs from the library witch says that the error has been notified.

I/flutter (23187): SpeechToText call: textRecognition {"finalResult":false,"alternates":[{"recognizedWords":"","confidence":-1}]}
I/flutter (23187): SpeechToText call: notifyError {"errorMsg":"error_no_match","permanent":true}
@BogdanSinitsa
Copy link
Author

I have reverted to version 0.8.0. Now it works.

@sowens-csd
Copy link
Contributor

Can you give me the steps to reproduce this? The key difference in error handling in recent versions is that it now only notifies of an error while in listening mode isListening is true. From the log excerpt you included it looks like it should have been in listening mode but having the steps to reproduce would help.

@dcosta-desenbahia
Copy link

dcosta-desenbahia commented Mar 27, 2020

@sowens-csd

The problem is that the listening mode (isListening) is false because the _onNotifyStatus method is called before _onNotifyError method:

I/flutter (24989): SpeechToText call: notifyStatus notListening
I/flutter (24989): notListening
I/flutter (24989): SpeechToText call: notifyError {"errorMsg":"error_no_match","permanent":true}

_onNotifyError:

if ( isNotListening ) {
      return;
    }

@BogdanSinitsa
Copy link
Author

Can you give me the steps to reproduce this? The key difference in error handling in recent versions is that it now only notifies of an error while in listening mode isListening is true. From the log excerpt you included it looks like it should have been in listening mode but having the steps to reproduce would help.

Sorry for the long response.
The code is the same as from example.

Steps to reproduce.

  1. invoke 'listener' function
  2. say something indistinguishable. A sound or a word in another language.
  3. v0.7.1 - onError callback got called. v1.1.0 - nothing happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants