Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge: improve handling of bundled md #40

Closed
glpatcern opened this issue Jun 28, 2021 · 1 comment
Closed

Bridge: improve handling of bundled md #40

glpatcern opened this issue Jun 28, 2021 · 1 comment

Comments

@glpatcern
Copy link
Member

Imported from cs3org/wopibridge#9:

Summary: we need to keep CodiMD markdown files as .md and remove the conversion to .zmd. This avoids breaking sharing, versions and CodiMD revisions.

A "cloud-storage-oriented" way to achieve that is to replace the "upload file" dialog in CodiMD with the ownCloud file picker UI being developed. The file picker would need to create a public link on the fly, such that the CodiMD document would directly include a link of the form https://cernbox.cern.ch/index.php/s/<hash>/download (which works).

Another advantage will be that picture links within the .md files won't contain direct links to the CodiMD /uploads path (which would be entirely "disabled"), along with any reverse proxy routing that the service may expose.

This enhancement depends on the availability of the ownCloud/CERNBox file picker UI.

@glpatcern
Copy link
Member Author

As this was actually implemented in CodiMD, we now have both modes supported by the wopiserver: either "embedded CodiMD" in .zmd format, or "plain markdown" with links included by the filepicker.
This was implemented in 2847ccb so this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant