From 74f0df1b5a2be8b50ce3b1e28c71f24f594213a0 Mon Sep 17 00:00:00 2001 From: gmgigi96 Date: Fri, 14 Apr 2023 15:39:08 +0200 Subject: [PATCH 1/2] fix remove acl in eos storage driver --- pkg/eosclient/eosbinary/eosbinary.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/eosclient/eosbinary/eosbinary.go b/pkg/eosclient/eosbinary/eosbinary.go index fca2194f32..b120719363 100644 --- a/pkg/eosclient/eosbinary/eosbinary.go +++ b/pkg/eosclient/eosbinary/eosbinary.go @@ -314,6 +314,7 @@ func (c *Client) RemoveACL(ctx context.Context, auth, rootAuth eosclient.Authori return err } + a.Permissions = "" sysACL := a.CitrineSerialize() args := []string{"acl", "--sys"} if finfo.IsDir { From ef9fbce8dae1e6cc07987b863a1d97620e6aa778 Mon Sep 17 00:00:00 2001 From: gmgigi96 Date: Fri, 14 Apr 2023 15:50:37 +0200 Subject: [PATCH 2/2] add changelog --- changelog/unreleased/fix-unshare-eos.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 changelog/unreleased/fix-unshare-eos.md diff --git a/changelog/unreleased/fix-unshare-eos.md b/changelog/unreleased/fix-unshare-eos.md new file mode 100644 index 0000000000..bf8df7dc4e --- /dev/null +++ b/changelog/unreleased/fix-unshare-eos.md @@ -0,0 +1,9 @@ +Bugfix: Fix unshare for EOS storage driver + +In the EOS storage driver, the remove acl operation was a no-op. +After removing a share, the recipient of the share was still able +to operate on the shared resource. +Now this has been fixed, removing correctly the ACL from the shared +resource. + +https://github.com/cs3org/reva/pull/3794