From dc6776e13b4034633de05ffdd0e9d397ac124378 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20M=C3=BCller?= Date: Mon, 9 May 2022 09:54:37 +0200 Subject: [PATCH 1/3] Fix download action --- pkg/sdk/action/download.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/sdk/action/download.go b/pkg/sdk/action/download.go index 7f081a58fa..b80668cbb4 100644 --- a/pkg/sdk/action/download.go +++ b/pkg/sdk/action/download.go @@ -89,7 +89,7 @@ func (action *DownloadAction) Download(fileInfo *storage.ResourceInfo) ([]byte, func (action *DownloadAction) initiateDownload(fileInfo *storage.ResourceInfo) (*gateway.InitiateFileDownloadResponse, error) { // Initiating a download request gets us the download endpoint for the specified resource - req := &provider.InitiateFileDownloadRequest{Ref: &provider.Reference{ResourceId: fileInfo.Id}} + req := &provider.InitiateFileDownloadRequest{Ref: &provider.Reference{Path: fileInfo.Path}} res, err := action.session.Client().InitiateFileDownload(action.session.Context(), req) if err := net.CheckRPCInvocation("initiating download", res, err); err != nil { return nil, err From 766dbdf520957a70baa86c09334cc73d2aea6a7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20M=C3=BCller?= Date: Mon, 9 May 2022 09:58:29 +0200 Subject: [PATCH 2/3] Add changelog --- changelog/unreleased/sdk-download-fix.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelog/unreleased/sdk-download-fix.md diff --git a/changelog/unreleased/sdk-download-fix.md b/changelog/unreleased/sdk-download-fix.md new file mode 100644 index 0000000000..7f216ff010 --- /dev/null +++ b/changelog/unreleased/sdk-download-fix.md @@ -0,0 +1,5 @@ +Bugfix: SDK - Fix download action + +The download action was no longer working in the SDK (used by our testing probes); this PR fixes the underlying issue. + +https://github.com/cs3org/reva/pull/2842 From a79503914766c164441aa0cf20e099df649f2d2a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20M=C3=BCller?= Date: Mon, 16 May 2022 10:58:13 +0200 Subject: [PATCH 3/3] Restart CI pipeline --- changelog/unreleased/sdk-download-fix.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog/unreleased/sdk-download-fix.md b/changelog/unreleased/sdk-download-fix.md index 7f216ff010..8f03c24379 100644 --- a/changelog/unreleased/sdk-download-fix.md +++ b/changelog/unreleased/sdk-download-fix.md @@ -1,4 +1,4 @@ -Bugfix: SDK - Fix download action +Bugfix: Fix download action in SDK The download action was no longer working in the SDK (used by our testing probes); this PR fixes the underlying issue.