From 84be34feff11e89b2ee01274a241ff971d1d30d2 Mon Sep 17 00:00:00 2001 From: Willy Kloucek Date: Thu, 12 Aug 2021 12:26:11 +0200 Subject: [PATCH 1/2] remove prints for spaces --- pkg/storage/utils/decomposedfs/decomposedfs.go | 9 ++++----- pkg/storage/utils/decomposedfs/tree/tree.go | 16 ++++++++-------- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/pkg/storage/utils/decomposedfs/decomposedfs.go b/pkg/storage/utils/decomposedfs/decomposedfs.go index 122a329d28..b9995fa68e 100644 --- a/pkg/storage/utils/decomposedfs/decomposedfs.go +++ b/pkg/storage/utils/decomposedfs/decomposedfs.go @@ -23,7 +23,6 @@ package decomposedfs import ( "context" - "fmt" "io" "math" "net/url" @@ -232,10 +231,10 @@ func (fs *Decomposedfs) createStorageSpace(spaceType, nodeID string) error { } // we can reuse the node id as the space id - err := os.Symlink("../../nodes/"+nodeID, filepath.Join(fs.o.Root, "spaces", spaceType, nodeID)) - if err != nil { - fmt.Printf("could not create symlink for '%s' space %s, %s\n", spaceType, nodeID, err) - } + _ = os.Symlink("../../nodes/"+nodeID, filepath.Join(fs.o.Root, "spaces", spaceType, nodeID)) + //if err != nil { + // fmt.Printf("could not create symlink for '%s' space %s, %s\n", spaceType, nodeID, err) + //} return nil } diff --git a/pkg/storage/utils/decomposedfs/tree/tree.go b/pkg/storage/utils/decomposedfs/tree/tree.go index a9337658a0..770f260129 100644 --- a/pkg/storage/utils/decomposedfs/tree/tree.go +++ b/pkg/storage/utils/decomposedfs/tree/tree.go @@ -147,18 +147,18 @@ func (t *Tree) Setup(owner string) error { if isRootNode(nodePath) { // create personal space // we can reuse the node id as the space id - err = os.Symlink("../../nodes/"+nodes[i].Name(), filepath.Join(t.root, "spaces/personal", nodes[i].Name())) - if err != nil { - fmt.Printf("could not create symlink for personal space %s, %s\n", nodes[i].Name(), err) - } + _ = os.Symlink("../../nodes/"+nodes[i].Name(), filepath.Join(t.root, "spaces/personal", nodes[i].Name())) + //if err != nil { + // fmt.Printf("could not create symlink for personal space %s, %s\n", nodes[i].Name(), err) + //} } // is it a shared node? -> create shared space if isSharedNode(nodePath) { - err = os.Symlink("../../nodes/"+nodes[i].Name(), filepath.Join(t.root, "spaces/share", nodes[i].Name())) - if err != nil { - fmt.Printf("could not create symlink for shared space %s, %s\n", nodes[i].Name(), err) - } + _ = os.Symlink("../../nodes/"+nodes[i].Name(), filepath.Join(t.root, "spaces/share", nodes[i].Name())) + //if err != nil { + // fmt.Printf("could not create symlink for shared space %s, %s\n", nodes[i].Name(), err) + //} } } } else if !fi.IsDir() { From eb831937478f8911fbecec41802d79480ee5d9c7 Mon Sep 17 00:00:00 2001 From: Willy Kloucek Date: Thu, 12 Aug 2021 12:30:59 +0200 Subject: [PATCH 2/2] add changelog --- changelog/unreleased/fix-spaces-print-log.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 changelog/unreleased/fix-spaces-print-log.md diff --git a/changelog/unreleased/fix-spaces-print-log.md b/changelog/unreleased/fix-spaces-print-log.md new file mode 100644 index 0000000000..03e69e764b --- /dev/null +++ b/changelog/unreleased/fix-spaces-print-log.md @@ -0,0 +1,5 @@ +Bugfix: Remove fmt.Print statement from decomposedfs + +The logs have been spammed with messages like `could not create symlink for ...` when using the decomposedfs, eg. with the oCIS storage. + +https://github.com/cs3org/reva/pull/1988