diff --git a/changelog/unreleased/fix-spaces-print-log.md b/changelog/unreleased/fix-spaces-print-log.md new file mode 100644 index 0000000000..03e69e764b --- /dev/null +++ b/changelog/unreleased/fix-spaces-print-log.md @@ -0,0 +1,5 @@ +Bugfix: Remove fmt.Print statement from decomposedfs + +The logs have been spammed with messages like `could not create symlink for ...` when using the decomposedfs, eg. with the oCIS storage. + +https://github.com/cs3org/reva/pull/1988 diff --git a/pkg/storage/utils/decomposedfs/decomposedfs.go b/pkg/storage/utils/decomposedfs/decomposedfs.go index 122a329d28..b9995fa68e 100644 --- a/pkg/storage/utils/decomposedfs/decomposedfs.go +++ b/pkg/storage/utils/decomposedfs/decomposedfs.go @@ -23,7 +23,6 @@ package decomposedfs import ( "context" - "fmt" "io" "math" "net/url" @@ -232,10 +231,10 @@ func (fs *Decomposedfs) createStorageSpace(spaceType, nodeID string) error { } // we can reuse the node id as the space id - err := os.Symlink("../../nodes/"+nodeID, filepath.Join(fs.o.Root, "spaces", spaceType, nodeID)) - if err != nil { - fmt.Printf("could not create symlink for '%s' space %s, %s\n", spaceType, nodeID, err) - } + _ = os.Symlink("../../nodes/"+nodeID, filepath.Join(fs.o.Root, "spaces", spaceType, nodeID)) + //if err != nil { + // fmt.Printf("could not create symlink for '%s' space %s, %s\n", spaceType, nodeID, err) + //} return nil } diff --git a/pkg/storage/utils/decomposedfs/tree/tree.go b/pkg/storage/utils/decomposedfs/tree/tree.go index a9337658a0..770f260129 100644 --- a/pkg/storage/utils/decomposedfs/tree/tree.go +++ b/pkg/storage/utils/decomposedfs/tree/tree.go @@ -147,18 +147,18 @@ func (t *Tree) Setup(owner string) error { if isRootNode(nodePath) { // create personal space // we can reuse the node id as the space id - err = os.Symlink("../../nodes/"+nodes[i].Name(), filepath.Join(t.root, "spaces/personal", nodes[i].Name())) - if err != nil { - fmt.Printf("could not create symlink for personal space %s, %s\n", nodes[i].Name(), err) - } + _ = os.Symlink("../../nodes/"+nodes[i].Name(), filepath.Join(t.root, "spaces/personal", nodes[i].Name())) + //if err != nil { + // fmt.Printf("could not create symlink for personal space %s, %s\n", nodes[i].Name(), err) + //} } // is it a shared node? -> create shared space if isSharedNode(nodePath) { - err = os.Symlink("../../nodes/"+nodes[i].Name(), filepath.Join(t.root, "spaces/share", nodes[i].Name())) - if err != nil { - fmt.Printf("could not create symlink for shared space %s, %s\n", nodes[i].Name(), err) - } + _ = os.Symlink("../../nodes/"+nodes[i].Name(), filepath.Join(t.root, "spaces/share", nodes[i].Name())) + //if err != nil { + // fmt.Printf("could not create symlink for shared space %s, %s\n", nodes[i].Name(), err) + //} } } } else if !fi.IsDir() {