Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateReceivedShare of pkg ocm json driver does not actually persist the updated field #3747

Closed
redblom opened this issue Mar 23, 2023 · 0 comments · Fixed by #3749
Closed

Comments

@redblom
Copy link
Contributor

redblom commented Mar 23, 2023

Using the ocm share json driver, when accepting an ocm share the state field of the model is not actually updated to accepted (ie. not saved). Although the State field of the retrieved share is updated,

rs.State = share.State

the mrg model is not. And thus the update is not persisted. And listing the received share still shows it as pending.

This

rs, err := m.GetReceivedShare(ctx, user, &ocm.ShareReference{Spec: &ocm.ShareReference_Id{Id: share.Id}})

does not return a pointer to the model and thus the model is not updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant