Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker build failing in master #1999

Closed
michielbdejong opened this issue Aug 17, 2021 · 1 comment · Fixed by #2000
Closed

Docker build failing in master #1999

michielbdejong opened this issue Aug 17, 2021 · 1 comment · Fixed by #2000

Comments

@michielbdejong
Copy link
Contributor

https://drone.cernbox.cern.ch/cs3org/reva/2700/1/8

This is because the Nextcloud storage driver depends on a file from the tests/ folder, which is excluded by .dockerignore.

I'll think of a fix.
@michielbdejong michielbdejong mentioned this issue Aug 17, 2021
Merged
@michielbdejong
Copy link
Contributor Author

Should be easy to fix, but it's annoying that this wasn't caught by the PR checks.
I think a docker build would have been enough to catch this bug on the PR, testing that hypothesis now.

@michielbdejong michielbdejong mentioned this issue Aug 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep Nextcloud server mock out of main driver code michielbdejong/reva
1 participant
@michielbdejong