From d701636bd82589444280307894ab55adc9dccb4c Mon Sep 17 00:00:00 2001
From: David Christofas <dchristofas@owncloud.com>
Date: Tue, 12 Oct 2021 13:16:22 +0200
Subject: [PATCH] Augment the ID of newly created storage spaces (#2158)

---
 changelog/unreleased/augment-spaces-id.md                | 5 +++++
 .../grpc/services/storageprovider/storageprovider.go     | 9 ++++++++-
 2 files changed, 13 insertions(+), 1 deletion(-)
 create mode 100644 changelog/unreleased/augment-spaces-id.md

diff --git a/changelog/unreleased/augment-spaces-id.md b/changelog/unreleased/augment-spaces-id.md
new file mode 100644
index 0000000000..bcdad476b5
--- /dev/null
+++ b/changelog/unreleased/augment-spaces-id.md
@@ -0,0 +1,5 @@
+Enhancement: Augment the Id of new spaces
+
+Newly created spaces were missing the Root reference and the storage id in the space id.
+
+https://github.com/cs3org/reva/issues/2158
diff --git a/internal/grpc/services/storageprovider/storageprovider.go b/internal/grpc/services/storageprovider/storageprovider.go
index c6e6d7f060..0560c2278d 100644
--- a/internal/grpc/services/storageprovider/storageprovider.go
+++ b/internal/grpc/services/storageprovider/storageprovider.go
@@ -433,7 +433,14 @@ func (s *service) CreateHome(ctx context.Context, req *provider.CreateHomeReques
 
 // CreateStorageSpace creates a storage space
 func (s *service) CreateStorageSpace(ctx context.Context, req *provider.CreateStorageSpaceRequest) (*provider.CreateStorageSpaceResponse, error) {
-	return s.storage.CreateStorageSpace(ctx, req)
+	resp, err := s.storage.CreateStorageSpace(ctx, req)
+	if err != nil {
+		return nil, err
+	}
+
+	resp.StorageSpace.Root = &provider.ResourceId{StorageId: s.mountID, OpaqueId: resp.StorageSpace.Id.OpaqueId}
+	resp.StorageSpace.Id = &provider.StorageSpaceId{OpaqueId: s.mountID + "!" + resp.StorageSpace.Id.OpaqueId}
+	return resp, nil
 }
 
 func hasNodeID(s *provider.StorageSpace) bool {