From be54c4185640e466df0b66a745154ef4e6956494 Mon Sep 17 00:00:00 2001 From: Ishank Arora Date: Tue, 15 Jun 2021 18:08:55 +0200 Subject: [PATCH] Forward requests from stubs to pkg --- .../grpc/services/appregistry/appregistry.go | 43 +++++++++++++++---- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/internal/grpc/services/appregistry/appregistry.go b/internal/grpc/services/appregistry/appregistry.go index 419cb03757..49418e15a3 100644 --- a/internal/grpc/services/appregistry/appregistry.go +++ b/internal/grpc/services/appregistry/appregistry.go @@ -115,9 +115,17 @@ func (s *svc) GetAppProviders(ctx context.Context, req *registrypb.GetAppProvide } func (s *svc) AddAppProvider(ctx context.Context, req *registrypb.AddAppProviderRequest) (*registrypb.AddAppProviderResponse, error) { - return ®istrypb.AddAppProviderResponse{ - Status: status.NewUnimplemented(ctx, errtypes.NotSupported("AddAppProvider not implemented"), "AddAppProvider not implemented"), - }, nil + err := s.reg.AddProvider(ctx, req.Provider) + if err != nil { + return ®istrypb.AddAppProviderResponse{ + Status: status.NewInternal(ctx, err, "error adding the app provider"), + }, nil + } + + res := ®istrypb.AddAppProviderResponse{ + Status: status.NewOK(ctx), + } + return res, nil } func (s *svc) ListAppProviders(ctx context.Context, req *registrypb.ListAppProvidersRequest) (*registrypb.ListAppProvidersResponse, error) { @@ -136,13 +144,30 @@ func (s *svc) ListAppProviders(ctx context.Context, req *registrypb.ListAppProvi } func (s *svc) GetDefaultAppProviderForMimeType(ctx context.Context, req *registrypb.GetDefaultAppProviderForMimeTypeRequest) (*registrypb.GetDefaultAppProviderForMimeTypeResponse, error) { - return ®istrypb.GetDefaultAppProviderForMimeTypeResponse{ - Status: status.NewUnimplemented(ctx, errtypes.NotSupported("GetDefaultAppProviderForMimeType not implemented"), "GetDefaultAppProviderForMimeType not implemented"), - }, nil + provider, err := s.reg.GetDefaultProviderForMimeType(ctx, req.MimeType) + if err != nil { + return ®istrypb.GetDefaultAppProviderForMimeTypeResponse{ + Status: status.NewInternal(ctx, err, "error getting the default app provider for the mimetype"), + }, nil + } + + res := ®istrypb.GetDefaultAppProviderForMimeTypeResponse{ + Status: status.NewOK(ctx), + Provider: provider, + } + return res, nil } func (s *svc) SetDefaultAppProviderForMimeType(ctx context.Context, req *registrypb.SetDefaultAppProviderForMimeTypeRequest) (*registrypb.SetDefaultAppProviderForMimeTypeResponse, error) { - return ®istrypb.SetDefaultAppProviderForMimeTypeResponse{ - Status: status.NewUnimplemented(ctx, errtypes.NotSupported("SetDefaultAppProviderForMimeType not implemented"), "SetDefaultAppProviderForMimeType not implemented"), - }, nil + err := s.reg.SetDefaultProviderForMimeType(ctx, req.MimeType, req.Provider) + if err != nil { + return ®istrypb.SetDefaultAppProviderForMimeTypeResponse{ + Status: status.NewInternal(ctx, err, "error setting the default app provider for the mimetype"), + }, nil + } + + res := ®istrypb.SetDefaultAppProviderForMimeTypeResponse{ + Status: status.NewOK(ctx), + } + return res, nil }