From b3ef45ebeac864b764452c7afc99746beb531806 Mon Sep 17 00:00:00 2001 From: Giuseppe Lo Presti Date: Thu, 15 Jun 2023 15:57:49 +0200 Subject: [PATCH] Fixed panic (#3972) --- changelog/unreleased/patch-3971.md | 5 +++++ pkg/ocm/share/repository/nextcloud/nextcloud.go | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 changelog/unreleased/patch-3971.md diff --git a/changelog/unreleased/patch-3971.md b/changelog/unreleased/patch-3971.md new file mode 100644 index 0000000000..cc7664cefe --- /dev/null +++ b/changelog/unreleased/patch-3971.md @@ -0,0 +1,5 @@ +Bugfix: Fix for #3971 + +Fixed panic described in #3971 + +https://github.com/cs3org/reva/pull/3972 diff --git a/pkg/ocm/share/repository/nextcloud/nextcloud.go b/pkg/ocm/share/repository/nextcloud/nextcloud.go index 775f370a47..76825d99e5 100644 --- a/pkg/ocm/share/repository/nextcloud/nextcloud.go +++ b/pkg/ocm/share/repository/nextcloud/nextcloud.go @@ -406,10 +406,10 @@ func (sm *Manager) UpdateReceivedShare(ctx context.Context, user *userpb.User, s } func getUsername(user *userpb.User) string { - if len(user.Username) > 0 { + if user != nil && len(user.Username) > 0 { return user.Username } - if len(user.Id.OpaqueId) > 0 { + if user != nil && len(user.Id.OpaqueId) > 0 { return user.Id.OpaqueId }