From 937db22af70c18fddec1c0bfe1cf295c88302ac9 Mon Sep 17 00:00:00 2001 From: Willy Kloucek <34452982+wkloucek@users.noreply.github.com> Date: Wed, 6 Oct 2021 18:02:24 +0200 Subject: [PATCH] make TUS capabilities configurable (#2136) --- .../unreleased/configurable-tus-capabilities.md | 5 +++++ .../ocs/handlers/cloud/capabilities/uploads.go | 15 ++++++++------- 2 files changed, 13 insertions(+), 7 deletions(-) create mode 100644 changelog/unreleased/configurable-tus-capabilities.md diff --git a/changelog/unreleased/configurable-tus-capabilities.md b/changelog/unreleased/configurable-tus-capabilities.md new file mode 100644 index 0000000000..827e7cea53 --- /dev/null +++ b/changelog/unreleased/configurable-tus-capabilities.md @@ -0,0 +1,5 @@ +Bugfix: Make TUS capabilities configurable + +We've fixed the configuration for the TUS capabilities, which will now take the given configuration instead of always using hardcoded defaults. + +https://github.com/cs3org/reva/pull/2135 diff --git a/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/uploads.go b/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/uploads.go index 9a17cf8e13..4fba150d25 100644 --- a/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/uploads.go +++ b/internal/http/services/owncloud/ocs/handlers/cloud/capabilities/uploads.go @@ -67,12 +67,13 @@ func setCapabilitiesForChunkProtocol(cp chunkProtocol, c *data.CapabilitiesData) c.Capabilities.Dav.Chunking = "" // TODO: infer from various TUS handlers from all known storages - c.Capabilities.Files.TusSupport = &data.CapabilitiesFilesTusSupport{ - Version: "1.0.0", - Resumable: "1.0.0", - Extension: "creation,creation-with-upload", - MaxChunkSize: 0, - HTTPMethodOverride: "", - } + // until now we take the manually configured tus options + // c.Capabilities.Files.TusSupport = &data.CapabilitiesFilesTusSupport{ + // Version: "1.0.0", + // Resumable: "1.0.0", + // Extension: "creation,creation-with-upload", + // MaxChunkSize: 0, + // HTTPMethodOverride: "", + // } } }