diff --git a/internal/grpc/services/gateway/gateway.go b/internal/grpc/services/gateway/gateway.go index 35c14d737b4..25819dfb22c 100644 --- a/internal/grpc/services/gateway/gateway.go +++ b/internal/grpc/services/gateway/gateway.go @@ -57,6 +57,7 @@ type config struct { GroupProviderEndpoint string `mapstructure:"groupprovidersvc"` DataTxEndpoint string `mapstructure:"datatx"` DataGatewayEndpoint string `mapstructure:"datagateway"` + PermissionsEndpoint string `mapstructure:"permissionssvc"` CommitShareToStorageGrant bool `mapstructure:"commit_share_to_storage_grant"` CommitShareToStorageRef bool `mapstructure:"commit_share_to_storage_ref"` DisableHomeCreationOnLogin bool `mapstructure:"disable_home_creation_on_login"` @@ -71,7 +72,6 @@ type config struct { EtagCacheTTL int `mapstructure:"etag_cache_ttl"` AllowedUserAgents map[string][]string `mapstructure:"allowed_user_agents"` // map[path][]user-agent CreateHomeCacheTTL int `mapstructure:"create_home_cache_ttl"` - PermissionsEndpoint string `mapstructure:"permissionssvc"` } // sets defaults diff --git a/pkg/permission/manager/ocisci/ocisci.go b/pkg/permission/manager/demo/demo.go similarity index 88% rename from pkg/permission/manager/ocisci/ocisci.go rename to pkg/permission/manager/demo/demo.go index 340bc88db67..7bb6c107798 100644 --- a/pkg/permission/manager/ocisci/ocisci.go +++ b/pkg/permission/manager/demo/demo.go @@ -16,7 +16,7 @@ // granted to it by virtue of its status as an Intergovernmental Organization // or submit itself to any jurisdiction. -package ocisci +package demo import ( provider "github.com/cs3org/go-cs3apis/cs3/storage/provider/v1beta1" @@ -25,10 +25,10 @@ import ( ) func init() { - registry.Register("ocisci", New) + registry.Register("demo", New) } -// New returns a new permission manager specific for the CI +// New returns a new demo permission manager func New(c map[string]interface{}) (permission.Manager, error) { return manager{}, nil } @@ -37,7 +37,7 @@ type manager struct { } func (m manager) CheckPermission(permission string, subject string, ref *provider.Reference) bool { - // We can currently return false all the time. + // We can currently return true all the time. // Once we beginn testing roles we need to somehow check the roles of the users here - return false + return true } diff --git a/pkg/permission/manager/loader/loader.go b/pkg/permission/manager/loader/loader.go index a1598bd3883..5f0bbc5774b 100644 --- a/pkg/permission/manager/loader/loader.go +++ b/pkg/permission/manager/loader/loader.go @@ -20,6 +20,6 @@ package loader import ( // Load permission manager drivers - _ "github.com/cs3org/reva/pkg/permission/manager/ocisci" + _ "github.com/cs3org/reva/pkg/permission/manager/demo" // Add your own here )