diff --git a/changelog/unreleased/fix-group-get.md b/changelog/unreleased/fix-group-get.md new file mode 100644 index 0000000000..ee002a21ef --- /dev/null +++ b/changelog/unreleased/fix-group-get.md @@ -0,0 +1,6 @@ +Bugfix: Fix group request to Grappa + +The `url.JoinPath` call was returning an url-encoded string, turning `?` into +`%3`. This caused the request to return 404. + +https://github.com/cs3org/reva/pull/3883 diff --git a/pkg/cbox/group/rest/rest.go b/pkg/cbox/group/rest/rest.go index 3466af8b55..43345f4093 100644 --- a/pkg/cbox/group/rest/rest.go +++ b/pkg/cbox/group/rest/rest.go @@ -21,7 +21,6 @@ package rest import ( "context" "fmt" - "net/url" "os" "os/signal" "strings" @@ -277,10 +276,7 @@ func (m *manager) GetMembers(ctx context.Context, gid *grouppb.GroupId) ([]*user return users, nil } - url, err := url.JoinPath(m.conf.APIBaseURL, "/api/v1.0/Group", gid.OpaqueId, "/memberidentities/precomputed?limit=10&field=upn&field=primaryAccountEmail&field=displayName&field=uid&field=gid&field=type&field=source") - if err != nil { - return nil, err - } + url := fmt.Sprintf("%s/api/v1.0/Group/%s/memberidentities/precomputed?limit=10&field=upn&field=primaryAccountEmail&field=displayName&field=uid&field=gid&field=type&field=source", m.conf.APIBaseURL, gid.OpaqueId) var r user.IdentitiesResponse members := []*userpb.UserId{}