From 1c9d29e15525bf80617b033d45b7e56a8c48bab5 Mon Sep 17 00:00:00 2001 From: Ilja Neumann Date: Thu, 26 Nov 2020 14:16:31 +0100 Subject: [PATCH] Set "Not Found" log-line to debug level (#1335) 404 is an expected signal during normal operation thus should not be logged as application error. --- pkg/rhttp/datatx/manager/simple/simple.go | 2 +- pkg/rhttp/datatx/manager/tus/tus.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/rhttp/datatx/manager/simple/simple.go b/pkg/rhttp/datatx/manager/simple/simple.go index 8793d1cfb4..03700aefea 100644 --- a/pkg/rhttp/datatx/manager/simple/simple.go +++ b/pkg/rhttp/datatx/manager/simple/simple.go @@ -81,7 +81,7 @@ func (m *manager) Handler(fs storage.FS) (http.Handler, error) { rc, err := fs.Download(ctx, ref) if err != nil { if _, ok := err.(errtypes.IsNotFound); ok { - log.Err(err).Msg("datasvc: file not found") + log.Debug().Err(err).Msg("datasvc: file not found") w.WriteHeader(http.StatusNotFound) } else { log.Err(err).Msg("datasvc: error downloading file") diff --git a/pkg/rhttp/datatx/manager/tus/tus.go b/pkg/rhttp/datatx/manager/tus/tus.go index 3453054562..ea2b9df153 100644 --- a/pkg/rhttp/datatx/manager/tus/tus.go +++ b/pkg/rhttp/datatx/manager/tus/tus.go @@ -123,7 +123,7 @@ func (m *manager) Handler(fs storage.FS) (http.Handler, error) { rc, err := fs.Download(ctx, ref) if err != nil { if _, ok := err.(errtypes.IsNotFound); ok { - log.Err(err).Msg("datasvc: file not found") + log.Debug().Err(err).Msg("datasvc: file not found") w.WriteHeader(http.StatusNotFound) } else { log.Err(err).Msg("datasvc: error downloading file")