Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Top level EventDefinition #2226

Closed
FaybianB opened this issue Nov 9, 2023 · 1 comment
Closed

Add Support For Top level EventDefinition #2226

FaybianB opened this issue Nov 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@FaybianB
Copy link

FaybianB commented Nov 9, 2023

Describe the desired feature

As of Solidity 0.8.22, events are allowed to be declared at the file level. However, attempting to run Slither on a file with events declared at the file level results in an slither.exceptions.SlitherException: Top level EventDefinition not supported

The tool should be updated to properly parse and support top-level event definitions.

@FaybianB FaybianB added the enhancement New feature or request label Nov 9, 2023
@smonicas
Copy link
Contributor

smonicas commented Nov 9, 2023

There is an open issue about this #2205 and an open PR #2219 which should already work, you can try it and leave comments if you encounter problems. I close this issue in favor of tracking it in the original one.

@smonicas smonicas closed this as completed Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants