Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create slither-interface #1893

Closed
montyly opened this issue May 5, 2023 · 4 comments
Closed

Create slither-interface #1893

montyly opened this issue May 5, 2023 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@montyly
Copy link
Member

montyly commented May 5, 2023

See #1802 (comment)

@montyly montyly added help wanted Extra attention is needed good first issue Good for newcomers labels May 5, 2023
@0xGusMcCrae
Copy link
Contributor

I'll take a look at this over the weekend and see if I can get it done

@montyly
Copy link
Member Author

montyly commented May 6, 2023

That's great @0xGusMcCrae, let me know if you need guidance or help.

Some notes:

@0xGusMcCrae
Copy link
Contributor

I've got the basic functionality down. I just need to write some tests and I should have a PR ready tomorrow.

For the output, do we want to print the interface in the console and allow users to write to file manually?

i.e. slither-interface WETH9 0xC02aaA39b223FE8D0A0e5C4F27eAD9083C756Cc2 >> IWeth9.sol

Or should it write to file by default? Maybe a flag so there's an option between the two?

@montyly
Copy link
Member Author

montyly commented May 8, 2023

Awesome. I think a file is probably more appropriate.

Most of our tools use crytic-export/name_tool/contract, maybe we can do crytic-export/interfaces/ContractA.sol, crytic-export/interfaces/ContractB.sol, ... by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants