Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash after removing a function that is still in the corpus #287

Closed
rappie opened this issue Jan 27, 2024 · 4 comments · Fixed by #308
Closed

Crash after removing a function that is still in the corpus #287

rappie opened this issue Jan 27, 2024 · 4 comments · Fixed by #308
Labels
bug Something isn't working high-priority

Comments

@rappie
Copy link

rappie commented Jan 27, 2024

After removing a function from the code that is still in the corpus, in some cases this error happens:

image

@anishnaik
Copy link
Collaborator

anishnaik commented Jan 30, 2024

Hey @rappie thanks for calling this out. Seems like we should not be throwing an error here and I believe that somehow this has entered a codepath that it should not when in fact the corpus element should be thrown out.

Will mark this as a bug.

@anishnaik anishnaik added bug Something isn't working high-priority labels Jan 30, 2024
@anishnaik anishnaik added this to the Release 0.1.4: More bug fixes and improve call sequence shrinking milestone Jan 31, 2024
@anishnaik
Copy link
Collaborator

Hey @rappie after some more thought this seems like the correct behavior...If there was a function that was removed from the codebase but still exists in the corpus, it should throw an error. Would you prefer that medusa "disable" the element in case the method is no longer found?

@rappie
Copy link
Author

rappie commented Feb 12, 2024

I believe ignoring the sequence with incorrect function calls would be the best compromise between the amount of work and user friendliness.

If you decide to throw an error, there should be a more descriptive error text that explains the reason (ideally with the function name and not the 4byte). It would also be nice to have some option to remove it from the corpus on disk so you can keep using the corpus.

@anishnaik
Copy link
Collaborator

Noted, thanks @rappie . Will think about the best tradeoff here and get back to you on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants