-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash after removing a function that is still in the corpus #287
Comments
Hey @rappie thanks for calling this out. Seems like we should not be throwing an error here and I believe that somehow this has entered a codepath that it should not when in fact the corpus element should be thrown out. Will mark this as a bug. |
Hey @rappie after some more thought this seems like the correct behavior...If there was a function that was removed from the codebase but still exists in the corpus, it should throw an error. Would you prefer that medusa "disable" the element in case the method is no longer found? |
I believe ignoring the sequence with incorrect function calls would be the best compromise between the amount of work and user friendliness. If you decide to throw an error, there should be a more descriptive error text that explains the reason (ideally with the function name and not the |
Noted, thanks @rappie . Will think about the best tradeoff here and get back to you on this thread. |
After removing a function from the code that is still in the corpus, in some cases this error happens:
The text was updated successfully, but these errors were encountered: