Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miniscript Fragment C has no Attribute Name #259

Closed
Rob1Ham opened this issue Aug 13, 2023 · 3 comments
Closed

Miniscript Fragment C has no Attribute Name #259

Rob1Ham opened this issue Aug 13, 2023 · 3 comments
Milestone

Comments

@Rob1Ham
Copy link

Rob1Ham commented Aug 13, 2023

Running some tests, I have a miniscript output descriptor that will not be recognized by the Specter DIY:

{"label":"Test_Miniscript_Wallet","descriptor":"wsh(c:andor(multi(1,[d83593a2/48'/1'/0'/2']tpubDF4vhecRfUyYF5AEzfcFC7oNapKKVm24wdJmkjZ6QZefJsT6wAvFPotgAAPSCmWTDkysMHk9kv5pzwUDTNpDbAUj4vP6arLVt6YAysoan16/0/*,[9b5f84f8/48'/1'/0'/2']tpubDEDgqmrhRpSYBpSA7dbxg7kZYhsPgACWGPcLavmyJVqdh2ERL3ZNAnUu1HHbAVYK3Rcj25A1pQMWPDCcsbGeGdq7DsAxNVZnRFatNTsAKXw/0/*),pk_k([621f3bec/48'/1'/0'/2']tpubDEXD6B4sX85AyA3WJv1rB3NnADe8EvujnudmLTY8dmdgVKyUst3R65KQqAVyxY5q5USsMh9iqgGkDMtMzfV7zvRtUhV8timsH3H37P5C4Nt/0/*),pk_k([5d2e766d/48'/1'/0'/2']tpubDEdap7gaFhs35jNgpQhVadeKREP1XzPrD2DZDxbi3HRQL8CUDM1XWVsUYVD4HwWmECoe9hBFZsZT3w7ap282jVMA6XfF3VjUuYb2UGUrgze/0/*)))"}

Upon trying to upload this output descriptor, it shows the following error:

Screen 1

Screen 2

@stepansnigirev
Copy link
Contributor

Thanks!
This should fix it: diybitcoinhardware/embit#50

@Rob1Ham
Copy link
Author

Rob1Ham commented Aug 13, 2023

Thanks for the quick response! I'm working on building the firmware myself, including the updated embit library to reproduce and confirm the bug is fixed.

@stepansnigirev stepansnigirev added this to the Release 1.9.0 milestone Dec 4, 2023
@stepansnigirev
Copy link
Contributor

embit is updated in the repo with #264 , so should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants