This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: (Fix #972) Missing MultiSig pubkey methods in ClientRPC and ClientCLI #976
+121
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinlauyh
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
calvinlauyh
force-pushed
the
feature/972-multisig-pubkey-methods
branch
from
4fcb4c2 to
3fb0963
Compare
calvinlauyh
requested review from
yihuang,
foreseaz,
leejw51crypto and
linfeng-crypto
yihuang
reviewed
Jan 31, 2020
| @@ -9,9 +9,9 @@ __pycache__ | |||
| *.egg-info | |||
|
|
|||
| # Storage | |||
| /.storage* | |||
There was a problem hiding this comment.
supersedes the /.storage
There was a problem hiding this comment.
Removed /.storage, thanks!
calvinlauyh
force-pushed
the
feature/972-multisig-pubkey-methods
branch
from
3fb0963 to
9beeed5
Compare
yihuang
suggested changes
Jan 31, 2020
| #[rpc(name = "multiSig_newAddressPublicKey")] | ||
| fn new_address_public_key(&self, request: WalletRequest) -> Result<String>; | ||
|
|
||
| #[rpc(name = "multiSig_listAddressPublicKeys")] |
There was a problem hiding this comment.
The RPC endpoint name change is breaking, the test_watch_only_wallet.py and chainrpc.py needs to change accordingly.
|
bors try |
tryBuild failed |
tomtau
suggested changes
Jan 31, 2020
There was a problem hiding this comment.
fmt changed rules a little bit in 1.41: https://travis-ci.org/crypto-com/chain/jobs/644165204#L1784
some perhaps "cargo fmt" after "rustup update" should fix that?
|
and perhaps add an entry in CHANGELOG, as this is a breaking change |
tomtau
suggested changes
Feb 3, 2020
calvinlauyh
force-pushed
the
feature/972-multisig-pubkey-methods
branch
from
9beeed5 to
56d458c
Compare
Codecov Report
@@ Coverage Diff @@
## master #976 +/- ##
=========================================
- Coverage 67.18% 67% -0.18%
=========================================
Files 139 140 +1
Lines 18278 18327 +49
=========================================
Hits 12280 12280
- Misses 5998 6047 +49
|
…ntRPC and ClientCLI Solution: Add new and list methods to ClientRPC and ClientCLI
calvinlauyh
force-pushed
the
feature/972-multisig-pubkey-methods
branch
from
56d458c to
e97a9eb
Compare
|
bors try |
tryBuild succeeded |
|
bors r+ |
Build failed |
|
bors r+ |
Build failed |
|
bors retry |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Add new and list methods to ClientRPC and ClientCLI