This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem (Fix #1621): Can't deposit into other's new staking address #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
force-pushed
the
issue1621
branch
2 times, most recently
from
14bcca5 to
9b7899a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 70.31% 68.12% -2.20%
==========================================
Files 168 170 +2
Lines 21548 22247 +699
==========================================
+ Hits 15151 15155 +4
- Misses 6397 7092 +695
|
tomtau
suggested changes
May 20, 2020
tomtau
reviewed
May 20, 2020
Comment on lines
145
to
151
| let staked_state = self.get_staked_state(name, &to_address, verify_staking)?; | ||
| verify_unjailed(&staked_state).map_err(|e| { | ||
| Error::new( | ||
| ErrorKind::ValidationError, | ||
| format!("Failed to validate staking account: {}", e), | ||
| ) | ||
| })?; |
There was a problem hiding this comment.
maybe the jailing test could be optionally run (if the state exists?)
yihuang
force-pushed
the
issue1621
branch
2 times, most recently
from
40bd70e to
335ceb6
Compare
Done |
client-rpc is also affected if client-network changed? |
… address Solution: - Remove the restriction from client network ops code - Add check and double confirmation in client-cli
Yes, just bumped the version too, and reflected that in CHANGELOG. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: