Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem (Fix #1506): block fetch failed when there is evidence in it #1508

Merged
merged 1 commit into from
Apr 29, 2020
Merged

Problem (Fix #1506): block fetch failed when there is evidence in it #1508

merged 1 commit into from
Apr 29, 2020

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 28, 2020 •
edited
Loading

Solution:

  • fix the evidence encoding in tendermint-rs

@yihuang yihuang force-pushed the master branch 3 times, most recently from 9f8712a to c8fc5c1 Compare April 28, 2020 16:48
@codecov
Copy link

codecov bot commented Apr 28, 2020 •
edited
Loading

Codecov Report

Merging #1508 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1508   +/-   ##
=======================================
  Coverage   65.30%   65.30%           
=======================================
  Files         162      162           
  Lines       21575    21575           
=======================================
  Hits        14090    14090           
  Misses       7485     7485

@yihuang yihuang changed the title Problem (WIP #1506): block fetch failed when there is evidence in it Problem (Fix #1506): block fetch failed when there is evidence in it Apr 29, 2020
@yihuang yihuang force-pushed the master branch 3 times, most recently from cceb206 to c0d09b8 Compare April 29, 2020 02:17
@yihuang
Problem (Fix crypto-com#1506): block fetch failed when there is evide…
2de1aae 
…nce in it

Solution:
- fix the evidence encoding in tendermint-rs
tomtau
tomtau approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 29, 2020

Build succeeded:

@bors bors bot merged commit 8dd02d3 into crypto-com:master Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leejw51crypto leejw51crypto leejw51crypto approved these changes

@tomtau tomtau tomtau approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @tomtau @leejw51crypto