This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem: duplicate storage between chain-abci and tx-validation app (fixes #866) #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtau
requested review from
yihuang,
foreseaz,
calvinaco,
devashishdxt,
leejw51crypto and
linfeng-crypto
|
bors try |
tryBuild failed |
yihuang
reviewed
Feb 14, 2020
yihuang
reviewed
Feb 14, 2020
yihuang
reviewed
Feb 14, 2020
yihuang
reviewed
Feb 14, 2020
devashishdxt
suggested changes
Feb 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #1073 +/- ##
==========================================
+ Coverage 66.26% 66.41% +0.14%
==========================================
Files 147 145 -2
Lines 18791 18792 +1
==========================================
+ Hits 12452 12480 +28
+ Misses 6339 6312 -27
|
tomtau
force-pushed
the
fix/duplicate-storage
branch
from
6aa4cf3 to
dfaaac9
Compare
|
bors try |
|
This pull request introduces 2 alerts when merging dfaaac9 into 7c173ec - view on LGTM.com new alerts:
|
|
bors try |
tryAlready running a review |
tryBuild succeeded |
|
bors try |
…ixes crypto-com#866) Solution: as a part of ADR-001: https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-001.md - tx-validation-app moved to chain-abci - chain-abci build process expanded to handle SGX SDK steps for C stubs -- on non-Linux systems, it'd display a warning and compile the mock version - tx-validation-app SGX unit test moved to chain-abci under a "sgx-test" feature flag - tx-query-app test removed (it was a kind of "mini-integration" / functionality test that assumed a lot of old behaviour, and all of this is now tested in integration tests) - enclave-bridge takes "intra enclave" requests that are passed directly to the ecalls and returns the response - ZMQ server started in chain-abci in a separate thread to handle tx-query requests (note: tx-query was out of scope of ADR-001, as it doesn't have any storage -- its future is TBD depending on audit feedback etc.) - redundant enclave protocol variants removed - "readonly" storage version provided for serving tx-query requests -- rocksdb/kvdb is thread-safe... zmq server then takes the latest chain state or sealed transactions directly -- note: some fixes related to fees, enclave protocol etc. (other steps of ADR-001) would be addressed in a separate PR - chain-abci storage expanded with one column for sealed transaction payloads - integration test building and environment preparation updated note: Makefile + chain-docs aren't updated yet / would be addressed in separate PRs
tomtau
force-pushed
the
fix/duplicate-storage
branch
from
98cfd01 to
c98d677
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 16, 2020
1073: Problem: duplicate storage between chain-abci and tx-validation app (fixes #866) r=tomtau a=tomtau Solution: as a part of ADR-001: https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-001.md - tx-validation-app moved to chain-abci - chain-abci build process expanded to handle SGX SDK steps for C stubs -- on non-Linux systems, it'd display a warning and compile the mock version - tx-validation-app SGX unit test moved to chain-abci under a "sgx-test" feature flag - tx-query-app test removed (it was a kind of "mini-integration" / functionality test that assumed a lot of old behaviour, and all of this is now tested in integration tests) - enclave-bridge takes "intra enclave" requests that are passed directly to the ecalls and returns the response - ZMQ server started in chain-abci in a separate thread to handle tx-query requests (note: tx-query was out of scope of ADR-001, as it doesn't have any storage -- its future is TBD depending on audit feedback etc.) - redundant enclave protocol variants removed - "readonly" storage version provided for serving tx-query requests -- rocksdb/kvdb is thread-safe... zmq server then takes the latest chain state or sealed transactions directly -- note: some fixes related to fees, enclave protocol etc. (other steps of ADR-001) would be addressed in a separate PR - chain-abci storage expanded with one column for sealed transaction payloads - integration test building and environment preparation updated note: Makefile + chain-docs aren't updated yet / would be addressed in separate PRs Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
tryBuild succeeded |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: as a part of ADR-001: https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-001.md
note: Makefile + chain-docs aren't updated yet / would be addressed in separate PRs