Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: No way to display transaction details in client-cli #1058

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Problem: No way to display transaction details in client-cli #1058

merged 1 commit into from
Feb 12, 2020

Conversation

devashishdxt
Copy link
Collaborator

@devashishdxt devashishdxt commented Feb 12, 2020 •
edited
Loading

Solution: Added transaction show command to display all the transaction information. Fixes #968.

leejw51crypto
leejw51crypto approved these changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devashishdxt
Problem: No way to display transaction details in client-cli
e0d9ab6 
Solution: Added `transaction show` command to display all the
transaction information
@codecov
Copy link

codecov bot commented Feb 12, 2020 •
edited
Loading

Codecov Report

Merging #1058 into master will decrease coverage by 0.5%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
- Coverage   66.77%   66.26%   -0.51%     
==========================================
  Files         147      147              
  Lines       18651    18793     +142     
==========================================
  Hits        12454    12454              
- Misses       6197     6339     +142
Impacted Files Coverage Δ
client-cli/src/command/transaction_command.rs 0% <0%> (ø) ⬆️
client-core/src/service/wallet_state_service.rs 87.63% <0%> (-1.97%) ⬇️
client-core/src/wallet/default_wallet_client.rs 42.34% <0%> (-0.65%) ⬇️

@tomtau
Copy link
Contributor

tomtau commented Feb 12, 2020

bors r+

bors bot added a commit that referenced this pull request Feb 12, 2020
@bors @devashishdxt
Merge #1058
e33dfe4 
1058: Problem: No way to display transaction details in client-cli r=tomtau a=devashishdxt

Solution: Added `transaction show` command to display all the transaction information. Fixes #968.

Co-authored-by: Devashish Dixit <devashishdxt@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 12, 2020

Build succeeded

@bors bors bot merged commit e0d9ab6 into crypto-com:master Feb 12, 2020
@devashishdxt devashishdxt deleted the issue-968 branch February 13, 2020 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leejw51crypto leejw51crypto leejw51crypto approved these changes

@yihuang yihuang Awaiting requested review from yihuang

@tomtau tomtau Awaiting requested review from tomtau

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

@lezzokafka lezzokafka Awaiting requested review from lezzokafka

@linfeng-crypto linfeng-crypto Awaiting requested review from linfeng-crypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: no way to display transaction details in client-cli
3 participants
@devashishdxt @tomtau @leejw51crypto