This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem (Fix #1007): liveness tracker doesn't contain information about some nodes in multi-node integration test #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
devashishdxt
approved these changes
Feb 12, 2020
…mation about some nodes in multi-node integration test Solution: - Check `tendermint_validator_addresses` when `liveness_tracker` not found, if cleaned up, log error, otherwise log info. Update chain-abci/src/app/app_init/validator_state.rs Co-Authored-By: Devashish Dixit <devashish@crypto.com>
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
==========================================
- Coverage 66.81% 66.76% -0.05%
==========================================
Files 147 147
Lines 19004 18651 -353
==========================================
- Hits 12697 12453 -244
+ Misses 6307 6198 -109
|
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 12, 2020
1055: Problem (Fix #1007): liveness tracker doesn't contain information about some nodes in multi-node integration test r=tomtau a=yihuang Solution: - Check `tendermint_validator_addresses` when `liveness_tracker` not found, if cleaned up, log error otherwise log info. Co-authored-by: yihuang <huang@crypto.com>
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
tendermint_validator_addresseswhenliveness_trackernot found, if cleaned up, log error otherwise log info.