Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dependabot PRs request review from both maintainers and reviewers #118

Closed
andrewazores opened this issue Oct 24, 2023 · 2 comments · Fixed by #121
Closed

[Bug] Dependabot PRs request review from both maintainers and reviewers #118

andrewazores opened this issue Oct 24, 2023 · 2 comments · Fixed by #121
Labels
bug Something isn't working

Comments

@andrewazores
Copy link
Member

Current Behavior

Dependabot PRs end up requesting review from both maintainers and reviewers teams.

Expected Behavior

It should only be maintainers.

Steps To Reproduce

No response

Environment

No response

Anything else?

CODEOWNERS file defines the files that are "protected" and require maintainers review. These are generally the same files/paths that Dependabot may update, so the .github/dependabot.yml should not specify reviewers directly.
@andrewazores andrewazores added the bug Something isn't working label Oct 24, 2023
@aali309
Copy link
Contributor

aali309 commented Oct 25, 2023 •
edited
Loading

so remove
reviewers: - "cryostatio/reviewers" ?

@andrewazores
Copy link
Member Author

Yes, I think that line should be removed from the dependabot config

@aali309 aali309 mentioned this issue Oct 25, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(dependabot): remove reviewers config aali309/cryostat
2 participants
@andrewazores @aali309