Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Use schema.ResourceTimeout to infer sync vs async Apply/Destroy #78

Open
turkenh opened this issue Oct 3, 2021 · 1 comment
Open

Use schema.ResourceTimeout to infer sync vs async Apply/Destroy #78

turkenh opened this issue Oct 3, 2021 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@turkenh
Copy link
Member

turkenh commented Oct 3, 2021

What problem are you facing?

In PR #76, @muvaf implemented two different modes for Apply and Destroy operations, namely sync and async.
Currently, the operation mode per resource is expected as input from provider developers. However, Terraform resource schema already has a per resource ResourceTimeout which was implemented by provider authors. We can leverage this information to decide on which mode to choose by default (still consider opening a configuration to override it).

For example, AWS RDS cluster has a default of 120 mins and we could choose the async mode. For resources that have no timeouts set or timeouts less than a sensible threshold, e.g. 5 mins, we can choose the sync mode.

How could Terrajet help solve your problem?

Leverage ResourceTimeout to decide which operation mode to use by default.

@turkenh turkenh added the enhancement New feature or request label Oct 3, 2021
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant