chore: bump crossplane runtime to v.1.18.0, add generics for external types #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: anagarlau <garlauanamaria@gmail.com>
anagarlau
changed the title
anagarlau
force-pushed
the
update-crossplaneruntime
branch
2 times, most recently
from
21c0143 to
4ddd3c5
Compare
MisterMX
requested changes
Feb 13, 2025
go.mod
Outdated
| go 1.21 | ||
| go 1.22.0 | ||
|
|
||
| toolchain go1.23.4 |
There was a problem hiding this comment.
I don't think we need this - for now.
anagarlau
force-pushed
the
update-crossplaneruntime
branch
from
4ddd3c5 to
b501f5f
Compare
…ate some controller names to be unique Signed-off-by: anagarlau <garlauanamaria@gmail.com>
anagarlau
force-pushed
the
update-crossplaneruntime
branch
from
b501f5f to
2c25fbb
Compare
MisterMX
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested