fix: attempt to fix the version problems of replicationgroups (#1) #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel.Humphries <daniel.humphries@sainsburys.co.uk>
dhumphries-sainsburys
force-pushed
the
master
branch
from
2b4ad73
to
47de9d6
Compare
|
LGMT. @dhumphries-sainsburys can you fix the linter issues? |
Signed-off-by: Daniel.Humphries <daniel.humphries@sainsburys.co.uk>
|
@MisterMX - Linting fixed |
MisterMX
approved these changes
Oct 2, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin release-0.49
git worktree add -d .worktree/backport-2088-to-release-0.49 origin/release-0.49
cd .worktree/backport-2088-to-release-0.49
git checkout -b backport-2088-to-release-0.49
ancref=$(git merge-base e39581216e69aea84b2bbba8ac9b7f1903f49c5a 049a2c4c953576a152fe76065e6f007f3f9f2a71)
git cherry-pick -x $ancref..049a2c4c953576a152fe76065e6f007f3f9f2a71 |
2 tasks
MisterMX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #2087
I have:
make reviewable testto ensure this PR is ready for review. <--- Doesn't exist and the crossplane contribution guide seems specific for the crossplane core