Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RolePolicy required field no data type, breaks things #1990

Closed
jpoley opened this issue Jan 24, 2024 · 1 comment · Fixed by #1993
Closed

RolePolicy required field no data type, breaks things #1990

jpoley opened this issue Jan 24, 2024 · 1 comment · Fixed by #1993
Labels
bug Something isn't working

Comments

@jpoley
Copy link

jpoley commented Jan 24, 2024

it seems like a new field is now required but doesn't have a data type here, can we please not do that.

https://marketplace.upbound.io/providers/crossplane-contrib/provider-aws/v0.46.0/resources/iam.aws.crossplane.io/RolePolicy/v1beta1#doc:spec-forProvider-document

anything required must have a datatype, we shouldn't need to go read the go code to see. this is a bit of a mess and feels like a hack.

the upbound one calls it something different and doesn't break it https://marketplace.upbound.io/providers/upbound/provider-aws/v0.47.1/resources/iam.aws.upbound.io/RolePolicy/v1beta1

this should be visible by looking at the the spec above
happens in all things running version 46

@jpoley jpoley added the bug Something isn't working label Jan 24, 2024
@jpoley
Copy link
Author

jpoley commented Jan 24, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant