17.17-beta4 Move and Attack, ranged penalty issues

[devakm]

Multiple issues here related to range penalty and/or Move and Attack.

First, Move and Attack has a ranged penalty of -2, not -4 as seen here:

Second, the #ranged tag is not working to apply the -2 penalty for missile spells if I invoke it within a larger OtF. I can create a simple OtF like [R:Fireball+1 Acc] and the tagged modifier works, but not if I do it in an OtF that casts the spell first like:

["Fireball"/r [/if [Sp:Fireball] cs:{/if [R:Fireball+1 Modifier Bucket Applied] {/:SpellDamage title=Fireball dice=1 adds=+2 type=burn adjust=-8 crit=true }} cf:{/rolltable CritMiss} s:{/if [R:Fireball+1 Modifier Bucket Applied] cs:{/:SpellDamage title=Fireball dice=1 adds=+2 type=burn adjust=-8 crit=true } s:{/:SpellDamage title=Fireball dice=1 adds=0 type=burn adjust=-2 crit=false} cf:{/rolltable CritMiss} f:{/fp -1}} f:{/fp -1} ]]

Third, the range penalty for distance to target is auto-tagged as Ranged and Spell, which makes sense for Regular spells (they get the #spell tag), but this is wrong for Missile spells. Unlike Regular spells, you cast a missile spell into your hand and then can hold onto it or attack with it using Innate Attack skill to make the Ranged [R:Fireball] hit roll, where the range penalty and Aim Accuracy +1 counts.

The whole idea of Ranged Accuracy is intended to offset the range penalty.

We may need to come up with a new way of distinguishing Missile spells from Regular spells to avoid this confusion.

[devakm]

Most of this ticket was resolved in another ticket except for the Move and Attack #ranged penalty, which is still applying -4 instead of the correct -2.

[mjeffw]

Give it a few hours...