Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyID support for RFC7517 #83

Closed
danikarik opened this issue Jan 14, 2021 · 1 comment
Closed

KeyID support for RFC7517 #83

danikarik opened this issue Jan 14, 2021 · 1 comment
Labels
feature New feature or request

Comments

@danikarik
Copy link
Contributor

Hi!

I've created PR in Centrifigo which uses your package as a dependency. What I'm trying to add is support for JWKS where encryption keys are rotating and to fetch appropriate public key kid header is used. See RFC

There is a problem with current Header which doesn't contain KeyID property. Previously it was presented in centrifugal/centrifugo#410.

I can create PR for that.
@danikarik danikarik mentioned this issue Jan 14, 2021
Closed
@cristaloleg
Copy link
Member

Hi @danikarik thank you for the PR. I'm aware of this issue in Centrifugo, so big thank you for fixing it.

There is one little problem....I've merged things to the master on a way to v4. Today I'll try to cleanup a bit and I might ask you to rebase your change (probably without any conflict). Hopefully you'll understand my point :)

@cristaloleg cristaloleg mentioned this issue Jan 14, 2021
Merged
@cristaloleg cristaloleg added the feature New feature or request label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cristaloleg @danikarik