Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign extension #45

Open
Hawk777 opened this issue Mar 31, 2024 · 4 comments
Open

Sign extension #45

Hawk777 opened this issue Mar 31, 2024 · 4 comments

Comments

@Hawk777
Copy link

Hawk777 commented Mar 31, 2024

The sign extension instructions (i32.extend8_s, i32.extend16_s, i64.extend8_s, i64.extend16_s, and i64.extend32_s) seem like they would map quite nicely onto efficient JVM code.

@Buzzec
Copy link

Buzzec commented Mar 31, 2024

These are part of the sign-extension operators extension (opcode ref). This is now considered default by LLVM.

@cretz
Copy link
Owner

cretz commented Apr 1, 2024

👍 I don't work on this project much anymore but if/when I get around to it, that and many other extensions would be added (e.g. GC)

@Hawk777
Copy link
Author

Hawk777 commented Apr 1, 2024

Not promising I’d have time or anything, but if I did, would you accept PRs?

@cretz
Copy link
Owner

cretz commented Apr 1, 2024

Yes, but I can't promise I'd review quickly. Also, you'd have to update the test harness surely, and unsure if you'd uncover any other bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants