From 8030f76a06d56e4583564ea9f095c44b009644d6 Mon Sep 17 00:00:00 2001
From: bhavanakarwade <137506897+bhavanakarwade@users.noreply.github.com>
Date: Thu, 11 Jul 2024 12:08:16 +0530
Subject: [PATCH] fix: parameter and response related bugs (#837)

* fix: send email verification issue

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* refcator: schema endorsement flow

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: resolved sonar lint issues

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: worked on sonarcloud issues

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: delete organization bugs

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: cred def id space fixes

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

* fix: create organization bug

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>

---------

Signed-off-by: bhavanakarwade <bhavana.karwade@ayanworks.com>
Signed-off-by: KulkarniShashank <shashank.kulkarni@ayanworks.com>
---
 apps/api-gateway/src/issuance/dtos/issuance.dto.ts   | 3 ++-
 apps/api-gateway/src/issuance/issuance.controller.ts | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/apps/api-gateway/src/issuance/dtos/issuance.dto.ts b/apps/api-gateway/src/issuance/dtos/issuance.dto.ts
index 1d40d8dd4..194cc0cfd 100644
--- a/apps/api-gateway/src/issuance/dtos/issuance.dto.ts
+++ b/apps/api-gateway/src/issuance/dtos/issuance.dto.ts
@@ -507,7 +507,8 @@ export class FileQuery {
 }
 
 export class RequestIdQuery {
-  @ApiProperty({ required: true })
+  @ApiPropertyOptional({ required: false })
+  @IsOptional()
   @IsString({ message: 'requestId should be string' })
   @IsNotEmpty({ message: 'requestId Id is required' })
   @Transform(({ value }) => trim(value))
diff --git a/apps/api-gateway/src/issuance/issuance.controller.ts b/apps/api-gateway/src/issuance/issuance.controller.ts
index 09b26d0b3..ffe109401 100644
--- a/apps/api-gateway/src/issuance/issuance.controller.ts
+++ b/apps/api-gateway/src/issuance/issuance.controller.ts
@@ -360,7 +360,7 @@ async downloadBulkIssuanceCSVTemplate(
     @Query(new ValidationPipe({ transform: true })) query: RequestIdQuery,
     @Query() previewFileDetails: PreviewFileDetails,
     @Res() res: Response
-  ): Promise<Response> {
+  ): Promise<object> {
 
     const { requestId } = query;
     const previewCSVDetails = await this.issueCredentialService.previewCSVDetails(requestId, orgId, previewFileDetails);
@@ -505,7 +505,7 @@ async downloadBulkIssuanceCSVTemplate(
   })
   async getFileDetailsByFileId(
     @Param('orgId') orgId: string,
-    @Param(new ValidationPipe({ transform: true })) query: FileQuery,
+    @Query(new ValidationPipe({ transform: true })) query: FileQuery,
     @Query() fileParameter: FileParameter,
     @Res() res: Response
   ): Promise<object> {