Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we remove all analytics code, such as Google Analytics #398

Closed
1 task done
brylie opened this issue Feb 1, 2022 · 0 comments · Fixed by #400
Closed
1 task done

Ensure we remove all analytics code, such as Google Analytics #398

brylie opened this issue Feb 1, 2022 · 0 comments · Fixed by #400
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@brylie
Copy link
Contributor

brylie commented Feb 1, 2022

We want to remove the analytics code so the Chooser can be used in other projects without any telemetry. We began the work with PR #391 but may have overlooked some Google Analytics code.

Task

  • remove all analytics related code, such as the following

chooser/src/App.vue

Lines 121 to 124 in 00099ae

// send home to google analytics
if (process.env.NODE_ENV === 'production') {
this.$ga.page('/');
}

@brylie brylie added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing feature 💻 aspect: code Concerns the software code in the repository labels Feb 1, 2022
@MuluhGodson MuluhGodson self-assigned this Feb 1, 2022
@MuluhGodson MuluhGodson mentioned this issue Feb 1, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing feature 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants