Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Footer on Chooser to Vocabulary #161

Closed
annatuma opened this issue May 6, 2020 · 4 comments · Fixed by #169
Closed

Update Footer on Chooser to Vocabulary #161

annatuma opened this issue May 6, 2020 · 4 comments · Fixed by #169
Labels
good first issue New-contributor friendly help wanted Open to participation from the community

Comments

@annatuma
Copy link

annatuma commented May 6, 2020

The footer on the License Chooser does not currently match the footer in Vocabulary. (It is possible this was implemented before the footer was available in Vocabulary?)

We should update the design to use the footer from Vocabulary. The only nav item in the footer should be the Feedback form link.
@annatuma annatuma added awaiting triage help wanted Open to participation from the community and removed awaiting triage labels May 6, 2020
@akmadian akmadian added the good first issue New-contributor friendly label May 10, 2020
@heraldofsolace
Copy link

Can I work on this?

@kgodey
Copy link
Member

kgodey commented May 15, 2020

@Herald-Of-Solace no need to ask for permission, go ahead.

@heraldofsolace
Copy link

@kgodey Thanks

@heraldofsolace heraldofsolace mentioned this issue May 16, 2020
Closed
This was referenced May 23, 2020
Closed
Merged
@obulat
Copy link
Contributor

obulat commented May 24, 2020

Yes, Anna, when I added the footer, it wasn't ready in Vocabulary just yet.
I looked into Vue Vocabulary now, but the Footer component there isn't ready yet. So, I copied footer from the cccatalog, please see in #169. Does Feedback look ok? Should it open in a new tab, or the same tab?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue New-contributor friendly help wanted Open to participation from the community
Projects
None yet
Milestone
No milestone
5 participants
@kgodey @annatuma @heraldofsolace @obulat @akmadian