Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Models - ExtraCredit #4

Open
creinkin opened this issue May 4, 2016 · 2 comments
Open

Django Models - ExtraCredit #4

creinkin opened this issue May 4, 2016 · 2 comments
Assignees

Comments

@creinkin
Copy link
Contributor

creinkin commented May 4, 2016

Use the ERD on the base readme of the repo to develop the ExtraCredit django model:

Do the following steps to complete the implementation

  1. Fill in the models.py with the model definition
  2. Register the model with the admin interface
  3. Overwrite the __str__ function to create a nicely formatted string to represent the object
  4. Make the migration for the model change (IMPORTANT NOTE: To not have migration naming conflicts between concurrent work, migrations should use the ‘name’ option available to the command https://docs.djangoproject.com/en/1.9/ref/django-admin/#cmdoption-makemigrations--name)
  5. Use git to commit and push all changes/new files to github master branch.
  6. Add label of 'ready to review' on this GitHub Issue for review by @creinkin
@creinkin
Copy link
Contributor Author

creinkin commented May 4, 2016

Blocked by #1 and #2. Can be worked after those are implemented.

@creinkin
Copy link
Contributor Author

creinkin commented May 5, 2016

There is duplication of effort in your __str__ function. You are essentially duplicating the Developer and Skill __str__ function rather than utilizing what has already been written.

Please fix this and recommit to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants