OR-5242 Practice URLSession
#68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazymanish
added a commit
that referenced
this pull request
Apr 4, 2023
* main: OR-5242 Practice `URLSession` (#68)
crazymanish
added a commit
that referenced
this pull request
Apr 4, 2023
* OR-5242-p2: OR-5242 Practice `URLSession` (#68)
buh
reviewed
Apr 4, 2023
| func testURLSessionPublisher() { | ||
| let expectation = XCTestExpectation(description: "Fetching GitHub user info") | ||
|
|
||
| publisher.sink { [weak self] completion in |
There was a problem hiding this comment.
You can use the convenient method:
URLSession.shared.dataTaskPublisher(for: url).sink { [weak self] completion in
buh
reviewed
Apr 4, 2023
Comment on lines
+23
to
+26
| let apiURL = URL(string: "https://api.github.com/users/crazymanish") | ||
| let urlRequest = URLRequest(url: apiURL!) | ||
| urlSession = URLSession.shared | ||
| publisher = URLSession.DataTaskPublisher(request: urlRequest, session: urlSession) |
There was a problem hiding this comment.
Instead of using real request, please take a look URLProtocol, e.g.
https://www.theinkedengineer.com/articles/mocking-requests-using-url-protocol
or https://www.google.com/search?q=mock+urlprotocol
This was referenced Apr 5, 2023
This was referenced Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
NotificationCenter#67In this PR
URLSessionTesting steps
cmd+u