Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OR-5240 Built-In publisher Deferred #63

Merged
merged 2 commits into from
Mar 30, 2023
Merged

OR-5240 Built-In publisher Deferred #63

merged 2 commits into from
Mar 30, 2023

Conversation

crazymanish
Copy link
Owner

Context

In this PR

Testing steps

  • Git checkout this pr git-branch
  • Open the project and cmd+u

Demo

Screenshot 2023-03-30 at 09 15 01

@crazymanish crazymanish added this to the Publisher milestone Mar 30, 2023
@crazymanish crazymanish requested review from buh and raihan March 30, 2023 07:15
.store(in: &cancellables)

XCTAssertTrue(isFinishedCalled)
XCTAssertEqual(receivedValue, 2) // Did you notice, Value is 2 means Deferred always create new publisher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More likely. How did you see it?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazymanish crazymanish merged commit 9775c8c into main Mar 30, 2023
@crazymanish crazymanish deleted the OR-5240-p5 branch March 30, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants